[Libguestfs] [PATCH v2 03/11] customize: fix windows firstboot script
Roman Kagan
rkagan at virtuozzo.com
Thu May 19 18:30:53 UTC 2016
On Wed, May 18, 2016 at 02:00:51PM +0200, Cédric Bosdonnat wrote:
> @@ -244,15 +244,14 @@ if not exist \"%%scripts_done%%\" (
>
> for %%%%f in (\"%%scripts%%\"\\*.bat) do (
> echo running \"%%%%f\"
> - call \"%%%%f\"
> - set elvl=!errorlevel!
> - echo .... exit code !elvl!
> - if !elvl! equ 0 (
> - move \"%%%%f\" \"%%scripts_done%%\"
> - )
> + move \"%%%%f\" \"%%scripts_done%%\"
> + pushd \"%%scripts_done%%\"
> + call \"%%%%~nf\"
> + popd
I think reporting the exit code was rather useful and didn't clutter the
log that much, so I'd rather keep it.
> )
>
> echo uninstalling firstboot service
> +rmdir /S /Q \"%%scripts_done%%\"
Please drop this, it makes debugging harder for no reason.
Roman.
More information about the Libguestfs
mailing list