[Libguestfs] [PATCH] customize: random_seed: avoid one file checking for existing files

Pino Toscano ptoscano at redhat.com
Thu May 26 11:45:05 UTC 2016


When the random-seed file is found, then avoid checking its existance
again.
---
 customize/random_seed.ml | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/customize/random_seed.ml b/customize/random_seed.ml
index e4c955e..1633aed 100644
--- a/customize/random_seed.ml
+++ b/customize/random_seed.ml
@@ -35,7 +35,7 @@ let rec set_random_seed (g : Guestfs.guestfs) root =
     List.iter (
       fun file ->
         if g#is_file file then (
-          make_random_seed_file g file;
+          make_random_seed_file g file ~exists:true;
           created := true
         )
     ) files;
@@ -71,8 +71,11 @@ let rec set_random_seed (g : Guestfs.guestfs) root =
 
   !created
 
-and make_random_seed_file g file =
-  let file_exists = g#is_file file in
+and make_random_seed_file ?exists g file =
+  let file_exists =
+    match exists with
+    | None -> g#is_file file
+    | Some b -> b in
   let n =
     if file_exists then (
       let n = Int64.to_int (g#filesize file) in
-- 
2.5.5




More information about the Libguestfs mailing list