[Libguestfs] [PATCH v2 5/6] New API: yara_scan

Pino Toscano ptoscano at redhat.com
Tue Nov 22 09:08:21 UTC 2016


On Wednesday, 9 November 2016 22:38:56 CET Matteo Cafasso wrote:
> +static char *
> +make_temp_file (guestfs_h *g, const char *name)
> +{
> +  int ret = 0;
> +
> +  ret = guestfs_int_lazy_make_tmpdir (g);
> +  if (ret < 0)
> +    return NULL;
> +
> +  return safe_asprintf (g, "%s/%s%d", g->tmpdir, name, ++g->unique);
> +}

Please do not bring a copy of this from src/tsk.c -- instead, first
make it an internal API:
- name it like guestfs_int_make_temp_file
- implemented in src/tmpdirs.c
- declared in src/guestfs-internal.h

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20161122/33343280/attachment.sig>


More information about the Libguestfs mailing list