[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] appliance: move virt-rescue welcome to /etc/issue



On Fri, 2016-07-22 at 11:57 +0200, Pino Toscano wrote:
> On Thursday, 21 July 2016 10:26:16 CEST C├ędric Bosdonnat wrote:
> > To allow easier downstream tweaks to the virt-rescue welcome message,
> > just output the content of the /etc/issue file in the appliance.
> > Thus, a new extras.tar.gz file appeared in supermin.d containing
> > the etc/issue file and future tweaks like this one.
> > ---
> 
> Why not include /etc/issue in daemon.tar.gz, and just patch
> appliance/issue downstream?
> 
> Also, which kind of tweaks are going to be done downstream? Is there
> anything that could be done directly upstream?
> I'd interested to know the reasons behind this before.

The change we do is to advertise for a helper script we provide (and could
possibly upstreamed for sure). This script called mount-rootfs-and-chroot.sh
mounts the root file system in /sysroot and chroot in it.

--
Cedric


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]