[Libguestfs] [PATCH v4 0/2] Improve OVA manifest parsing

[Pino Toscano]

On Wednesday, 5 October 2016 18:47:16 CEST Richard W.M. Jones wrote:
> On Wed, Oct 05, 2016 at 04:35:20PM +0200, Tomáš Golembiovský wrote:
> > This series fixes and enhances parsing of the OVA manifest file.
> > The changes are:
> > 
> > - Added mandatory space to the regexp
> > - Process all lines in the file, not just one
> > - Warn on improperly formated lines
> > - Support SHA256 hashes
> 
> Looks fine to me now.  Pino, any other comments?

LGTM as well.  The only improvement I see is modifying
v2v/test-v2v-i-ova.sh, so that in the generated test-ova.mf one of the
two SHA1 checksums is changed as SHA256 (so it is tested).

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20161006/a692f39c/attachment.sig>