[Libguestfs] [PATCH 3/3] v2v: bootloaders: improve detection of Grub2 default method

Tomáš Golembiovský tgolembi at redhat.com
Sun Oct 2 23:42:17 UTC 2016


On Tue, 27 Sep 2016 17:58:12 +0200
Pino Toscano <ptoscano at redhat.com> wrote:

> Detect only once which method must be used to get and set the default
> Grub2 kernel in the guest: this avoids the same checks in list_kernels
> and set_default_kernel.
> 
> Also, add a "no method" option as well: Debian/Ubuntu guests do not have
> neither grubby nor Perl's Bootloader::Tools, so there is no way to know
> what is the default kernel, nor to change it.  In this case, add a
> warning about this situation.
> ---
>  v2v/linux_bootloaders.ml | 61 ++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 44 insertions(+), 17 deletions(-)
> 

The series LGTM.

-- 
Tomáš Golembiovský <tgolembi at redhat.com>




More information about the Libguestfs mailing list