[Libguestfs] [PATCH 2/2] builder: consolidate handling of temporary files/dirs

[Pino Toscano]

On Monday, 24 October 2016 20:06:43 CEST Richard W.M. Jones wrote:
> My only comment on this series is it's hard to understand what
> the ?tmpdir parameter actually does without examining the code.
> 
> It specifically means that the Curl module writes a security-
> sensitive file to this directory (or the global tmpdir), and if
> the caller specifies ?tmpdir then it is their responsibility
> to remove the tmpdir later -- otherwise the file containing
> passwords etc is left around.

Yes, that is correct.

> Explaining it like that makes me think the deferred unlink when
> tmpdir is specified is a mistake.  The Curl module should always delete
> the file as soon as it can, even though it's not strictly necessary.

Makes sense, doing the deletion is not an issue anyway.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20161025/c6c5e6a0/attachment.sig>