[Libguestfs] [PATCH] v2v: Don't remove Processor and Intelppm nodes (RHBZ#1372668).
Roman Kagan
rkagan at virtuozzo.com
Fri Sep 2 11:46:23 UTC 2016
On Fri, Sep 02, 2016 at 12:27:11PM +0100, Richard W.M. Jones wrote:
> Don't remove the Processor and Intelppm nodes since that just breaks
> the device driver.
>
> The only remaining node being removed by the original code was
> "rhelscsi" (the xenpv-win driver). I changed this so that instead of
> deleting the whole node, it simply disables that driver. If you look
> at RHBZ#737600, it's not even clear that deleting nodes was the right
> fix for anything. I also renamed the function.
> ---
> v2v/convert_windows.ml | 23 ++++++-----------------
> 1 file changed, 6 insertions(+), 17 deletions(-)
Reviewed-by: Roman Kagan <rkagan at virtuozzo.com>
I've been always wondering if the problem those Processor / Intelppm
node deletions were supposed to address were less of a trouble than the
fix, but never had the energy to investigate it. Thanks for doing it!
Roman.
More information about the Libguestfs
mailing list