[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] v2v: utils: Replace "remove_duplicates" function with call to sort_uniq.



On Fri, Sep 09, 2016 at 04:45:27PM +0200, Pino Toscano wrote:
> On Friday, 9 September 2016 15:33:20 CEST Richard W.M. Jones wrote:
> > ---
> >  v2v/linux_bootloaders.ml | 2 +-
> >  v2v/utils.ml             | 9 ---------
> >  v2v/utils.mli            | 3 ---
> >  3 files changed, 1 insertion(+), 13 deletions(-)
> 
> Hm this may change the order of the grub1 kernels though.  Also the
> sorting done with a simple string comparison function will not always
> produce the right order, because of the possible version number of
> kernels.

Good points, let's forget about this patch.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]