[Libguestfs] [PATCH 1/2] v2v: -o glance: add property for UEFI firmware (RHBZ#1445659)

Pino Toscano ptoscano at redhat.com
Wed Apr 26 14:36:25 UTC 2017


When converting a guest with UEFI firmware, set the also
hw_firmware_type=uefi property for all the disks of the guest, so Nova
can properly boot the guest.
---
 v2v/output_glance.ml | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/v2v/output_glance.ml b/v2v/output_glance.ml
index b712d68..cfb19b4 100644
--- a/v2v/output_glance.ml
+++ b/v2v/output_glance.ml
@@ -41,7 +41,7 @@ object
 
   method as_options = "-o glance"
 
-  method supported_firmware = [ TargetBIOS ]
+  method supported_firmware = [ TargetBIOS; TargetUEFI ]
 
   method prepare_targets source targets =
     (* This does nothing useful except to check that the user has
@@ -66,9 +66,6 @@ object
     ) targets
 
   method create_metadata source targets _ guestcaps inspect target_firmware =
-    (* See #supported_firmware above. *)
-    assert (target_firmware = TargetBIOS);
-
     (* The first disk, assumed to be the system disk, will be called
      * "guestname".  Subsequent disks, assumed to be data disks,
      * will be called "guestname-disk2" etc.  The manual strongly
@@ -143,6 +140,11 @@ object
         (* XXX Neither memory balloon nor pvpanic are supported by
          * Glance at this time.
          *)
+        (match target_firmware with
+         | TargetBIOS -> ()
+         | TargetUEFI ->
+            push_back properties ("hw_firmware_type", "uefi")
+        );
 
         let properties =
           List.flatten (
-- 
2.9.3




More information about the Libguestfs mailing list