[Libguestfs] [PATCH] appliance: reorder the steps to search for appliance

[Richard W.M. Jones]

On Thu, Apr 27, 2017 at 03:54:44PM +0300, Pavel Butsykin wrote:
[...]
> >(2) If the fixed appliance was located somewhere else, you could do:
> >
> >   LIBGUESTFS_PATH=/path/to/somewhere/else:/usr/lib64/guestfs
> >   export LIBGUESTFS_PATH
> >
> >and then it would look for the fixed appliance in
> >/path/to/somewhere/else and use it.  If the fixed appliance exists
> >there, then it would never check /usr/lib64/guestfs.
> 
> It's a bit wrong, the first step is search supermin.d in all specified
> directories:
>   /* Step (1). */
>   r = find_path (g, contains_supermin_appliance, NULL, &supermin_path);
>   if (r == -1)
>     return -1;
> 
>   if (r == 1)
>     /* Step (2): build supermin appliance. */
>     return build_supermin_appliance (g, supermin_path,
>                                      kernel, initrd, appliance);

OK, I see, that is indeed a bug.  Can you suggest a patch which fixes
this so that directories are searched correctly?

However I still think that putting all of the appliances into a single
directory and expecting libguestfs to know which one you meant it to
choose first is the wrong idea.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v