[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Libguestfs] [PATCH v8 0/4] Import directly from OVA tar archive if possible

- split the big patch into several commits

- rebased because patch 1/3 has been pushed
- changes to nsplit have been dropped (2/3)
- addressed Richard's comments, notably the subfolder function was moved to
  mllib and renamed to subdirectory

- just rebase

- rebase, patches 1,3,5 were merged
- 1/3: we still need to discuss whether to detect compressed discs
- 2/3:
  - renamed argument noempty to keep_empty
  - tests were not run
- 3/3: 
  - using JSON module to generate JSON (as suggested by Pino)
  - all the other comments raised by Pino

- rebase to more recent master
- 1/6: using just "quote" instead of "Filename.quote"
- 2/6: reformated block of code according to Richards suggestion
- 4/6: added tests for nsplit

v3: Addressed Pino's comments, namely:
- input_ova.ml
  - untar takes list of paths
  - renamed untar_partial to untar_metadata
  - replaced uggly regex with nsplit
- tests
  - test changes are part of the main commit
  - renamed test-data/guestfs-hashsums.sh to test-data/test-utils.sh
  - renamed qemu_version to qemu_is_version and moved it to
  - normalize paths in expect files

- rewritten the tar invocations, the output processing is now done in
  OcaML rather than with a shell code; it turned out to be easier and
  more readable than I have feared.
- added QEMU version check
- addressed Pino's comments
- changed tests; the expected result is now based on the QEMU used
  during testing

This series is related to the problem of inefficient import of OVA
files. The needed enhancements of QEMU were merged into the codebase and
are available in QEMU 2.8. From there we can use 'size' and
'offset' options in raw driver to tell QEMU to use only subset of a file
as an image.

The patch set is more or less complete. The only outstanding issue is
the missing detection of sparse files inside tar. But this can be done
in a separate patch. As pointed out before I didn't find a way how to
detect that by using the tar tool only and would probably require use of
some external library.

Tomáš Golembiovský (4):
  mllib: add subdirectory function to common_utils
  v2v: add function qemu_img_version to utils
  v2v: add function find_file_in_tar to utils
  v2v: ova: don't extract files from OVA if it's not needed

 mllib/common_utils.ml                   |   9 +++
 mllib/common_utils.mli                  |  10 +++
 mllib/common_utils_tests.ml             |   7 ++
 test-data/test-utils.sh                 |  19 +++++
 v2v/Makefile.am                         |   2 +
 v2v/input_ova.ml                        | 109 +++++++++++++++++++++----
 v2v/test-v2v-i-ova-formats.sh           |   5 +-
 v2v/test-v2v-i-ova-subfolders.expected2 |  18 +++++
 v2v/test-v2v-i-ova-subfolders.sh        |  13 ++-
 v2v/test-v2v-i-ova-tar.expected         |  18 +++++
 v2v/test-v2v-i-ova-tar.expected2        |  18 +++++
 v2v/test-v2v-i-ova-tar.ovf              | 138 ++++++++++++++++++++++++++++++++
 v2v/test-v2v-i-ova-tar.sh               |  72 +++++++++++++++++
 v2v/test-v2v-i-ova-two-disks.expected2  |  19 +++++
 v2v/test-v2v-i-ova-two-disks.sh         |  13 ++-
 v2v/utils.ml                            |  72 +++++++++++++++++
 v2v/utils.mli                           |  12 +++
 17 files changed, 530 insertions(+), 24 deletions(-)
 create mode 100644 v2v/test-v2v-i-ova-subfolders.expected2
 create mode 100644 v2v/test-v2v-i-ova-tar.expected
 create mode 100644 v2v/test-v2v-i-ova-tar.expected2
 create mode 100644 v2v/test-v2v-i-ova-tar.ovf
 create mode 100755 v2v/test-v2v-i-ova-tar.sh
 create mode 100644 v2v/test-v2v-i-ova-two-disks.expected2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]