[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v8 2/4] v2v: add function qemu_img_version to utils



On Sat, Feb 04, 2017 at 03:10:44PM +0100, Tomáš Golembiovský wrote:
> The function returns version of qemu-img as a tuple (major, minor), or
> the value (0,9) in case there was an error detecting the version.

Depending on QEMU version is extremly unreliable.  Vendors often stick
with fairly old versions but backport important features (you at RedHat
know that, don't you ;)  So it's not unlikely that e.g. a number of
future RHEV/RHEL releases won't use this new feature even though the
included QEMU already supports it.

IMO a simpler and more reliable check is to construct a command line for
qemu-img that is lightweight to execute and succeeds if the option is
supported or fails otherwise.

[ sorry for being so late with this ]

Roman.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]