[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v2] v2v: ova: Don't rely on qemu-img version, test "offset"



On Mon, Feb 06, 2017 at 08:21:04PM +0000, Richard W.M. Jones wrote:
> v1 -> v2:
> 
> - Use 'qemu-img info' which avoids one of the temporary files
>   (thanks Tomáš).
> 
> - Add a unit test.
> 
> Unfortunately when I run 'make -C v2v check' I don't think this code
> is being run at all, so there may be something else going on here
> which I don't understand.

The code _is_ being run (adding an 'assert false' proves that),
I just wasn't enabling debugging when I thought I was.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]