[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v3 05/10] lib: extract osinfo DB traversing API

On Fri, Feb 10, 2017 at 04:06:00PM +0100, Cédric Bosdonnat wrote:
> +static struct osinfo *osinfo_db = NULL;
> +
> +

Extra blank line here.

> +static int
> +read_osinfo_db_xml (guestfs_h *g, const char *pathname, void *data);

Unsplit this.  Only put a function name at the beginning of a line if
that is the definition of the function, so you can easily find where a
function is defined by grepping for ^function_name.

This is a GNU coding standard; it's a shame it's not more widely
followed in the open source world.


The rest of this commit seems to be code motion AFAICT so that looks


Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]