[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 2/2] lib: allow to walk registry with corrupted blocks



Hi Rich,

Thanks for taking time to review my patches. 

On Tue, 2017-02-14 at 14:30 +0000, Richard W.M. Jones wrote:
> On Wed, Feb 08, 2017 at 04:36:31PM -0500, Dawid Zamirski wrote:
> > =
> > +        if (is_root) {
> > +          bad_root_block = 1;
> > +        } else {
> > +          DEBUG(2,
> 
> As before, space before parens in function and macro calls.

Sure, I'll be sending v2 with those fixed soon.
> 
> > @@ -408,7 +407,7 @@ _get_children (hive_h *h, hive_node_h blkoff,
> >        hive_node_h subkey = le32toh (lf->keys[i].offset);
> >        subkey += 0x1000;
> >        if (check_child_is_nk_block (h, subkey, flags) == -1)
> > -        return -1;
> > +        continue;
> 
> I think this deserves a debug message.
> 
> There is also a further call to check_child_is_nk_block in
> this function, but if that fails it still returns.  Why is
> that case different?
> 

I've simply missed it as the hive I was testing this against did not
hit the other code path. I'll take care of that other path as well and
re-test.

> Rich.
> 
> >        if (_hivex_add_to_offset_list (children, subkey) == -1)
> >          return -1;
> >      }
> > -- 
> > 2.9.3
> > 
> > _______________________________________________
> > Libguestfs mailing list
> > Libguestfs redhat com
> > https://www.redhat.com/mailman/listinfo/libguestfs
> 
> 

Regards,
Dawid


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]