[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v2 0/2] hivex: handle corrupted hives better



On Tue, Feb 14, 2017 at 12:05:19PM -0500, Dawid Zamirski wrote:
> The following patches address issues when dealing with hives that have
> corrupted data in them but are otherwise readable/writable. Those were
> found on some rather rare Windows installations that seem to work fine
> but current hivex fails to even open.
> 
> Those patches change hivex to simply log and ignore such "corrupted"
> regions instead of aborting because the caller might be looking at keys
> that are perfectly readable/writable (e.g. to identify Windows version
> from HKLM/Software/Microsoft/Windows NT/CurrentVersion) and other
> "corrupted" and irrelevant keys might prevent one from doing so.
> 
> Changes in v2:
>  * fixed code formatting
>  * added more debug statements
>  * do not depend on bad_root_block variable, instead report error and
>    exit if root block is corrupted
>  * handle the missed case where check_child_is_nk_block was still
>    returning instead of skipping faulty block with debug message

This is fine now, except for that annoying while loop issue ...
I couldn't see an easy for for that.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]