[Libguestfs] [PATCH v8 07/42] common/utils: Move ‘uefi.c’ to ‘lib/’.

[Pino Toscano]

On Wednesday, 21 June 2017 19:29:14 CEST Richard W.M. Jones wrote:
> This was only used inside the library, so move it there.
> ---

Not a problem with this, just noting down that theoretically the C
uefi.c does not need the i386, and x86_64 arrays (so making the library
slightly smaller).

> diff --git a/lib/guestfs-internal.h b/lib/guestfs-internal.h
> index ec70336e2..190b5cdd2 100644
> --- a/lib/guestfs-internal.h
> +++ b/lib/guestfs-internal.h
> @@ -1011,4 +1011,16 @@ extern bool guestfs_int_version_cmp_ge (const struct version *a, const struct ve
>  #define version_init_null(v) guestfs_int_version_from_values (v, 0, 0, 0)
>  #define version_is_null(v) ((v)->v_major == 0 && (v)->v_minor == 0 && (v)->v_micro == 0)
>  
> +/* uefi.c */
> +struct uefi_firmware {
> +  const char *code;		/* code file (NULL = end of list) */
> +  const char *code_debug;	/* code file with debugging msgs (may be NULL)*/
> +  const char *vars;		/* vars template file */
> +  int flags;                    /* various flags, see below */

While you are moving this code, can you please fix the indentation of
the above lines?  The first three are indented using tabs, and the last
using spaces.  (Any of the two is fine, as long as all the lines use
the same.)

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20170710/7f469922/attachment.sig>