[Libguestfs] [hivex PATCH 2/2] build: do not ignore pod2man error codes

Pino Toscano ptoscano at redhat.com
Fri Jul 14 10:02:11 UTC 2017


Move the temporary output of pod2man to the correct name only if pod2man
did not fail: this also makes the whole command fail if pod2man fails,
e.g. because of wrong markup.
---
 lib/Makefile.am     | 2 +-
 regedit/Makefile.am | 2 +-
 sh/Makefile.am      | 4 ++--
 xml/Makefile.am     | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/Makefile.am b/lib/Makefile.am
index f711f22..4a7cea1 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -61,7 +61,7 @@ hivex.3: hivex.pod
 	  -c "Windows Registry" \
 	  --name "hivex" \
 	  --release "$(PACKAGE_NAME)-$(PACKAGE_VERSION)" \
-	  $< > $@-t; mv $@-t $@
+	  $< > $@-t && mv $@-t $@
 
 noinst_DATA = \
 	$(top_builddir)/html/hivex.3.html
diff --git a/regedit/Makefile.am b/regedit/Makefile.am
index 476c059..749c221 100644
--- a/regedit/Makefile.am
+++ b/regedit/Makefile.am
@@ -28,7 +28,7 @@ hivexregedit.1: hivexregedit
 	  -c "Windows Registry" \
 	  --name "hivexregedit" \
 	  --release "$(PACKAGE_NAME)-$(PACKAGE_VERSION)" \
-	  $< > $@-t; mv $@-t $@
+	  $< > $@-t && mv $@-t $@
 
 noinst_DATA = \
 	$(top_builddir)/html/hivexregedit.1.html
diff --git a/sh/Makefile.am b/sh/Makefile.am
index 1c2aba8..98fdd05 100644
--- a/sh/Makefile.am
+++ b/sh/Makefile.am
@@ -51,7 +51,7 @@ hivexget.1: hivexget.pod
 	  -c "Windows Registry" \
 	  --name "hivexget" \
 	  --release "$(PACKAGE_NAME)-$(PACKAGE_VERSION)" \
-	  $< > $@-t; mv $@-t $@
+	  $< > $@-t && mv $@-t $@
 
 hivexsh.1: hivexsh.pod
 	$(POD2MAN) \
@@ -59,7 +59,7 @@ hivexsh.1: hivexsh.pod
 	  -c "Windows Registry" \
 	  --name "hivexsh" \
 	  --release "$(PACKAGE_NAME)-$(PACKAGE_VERSION)" \
-	  $< > $@-t; mv $@-t $@
+	  $< > $@-t && mv $@-t $@
 
 noinst_DATA = \
 	$(top_builddir)/html/hivexget.1.html \
diff --git a/xml/Makefile.am b/xml/Makefile.am
index ca3f964..3ebe2cc 100644
--- a/xml/Makefile.am
+++ b/xml/Makefile.am
@@ -40,7 +40,7 @@ hivexml.1: hivexml.pod
 	  -c "Windows Registry" \
 	  --name "hivexml" \
 	  --release "$(PACKAGE_NAME)-$(PACKAGE_VERSION)" \
-	  $< > $@-t; mv $@-t $@
+	  $< > $@-t && mv $@-t $@
 
 noinst_DATA = \
 	$(top_builddir)/html/hivexml.1.html
-- 
2.9.4




More information about the Libguestfs mailing list