[Libguestfs] [PATCH 01/27] build: Make OCaml compiler required for all builds.

[Richard W.M. Jones]

On Tue, Jul 18, 2017 at 05:54:52PM +0200, Pino Toscano wrote:
> On Friday, 14 July 2017 15:39:09 CEST Richard W.M. Jones wrote:
> > Previously the OCaml compiler was only required if building from git
> > but was at least theoretically optional if building from tarballs
> > (although this was never tested).  Since we want to write parts of the
> > daemon in OCaml, this makes OCaml required for all builds.
> > 
> > Note that the ‘--disable-ocaml’ option remains, but it now only
> > disables OCaml bindings and OCaml virt tools.  Using this option does
> > not disable the OCaml compiler requirement.
> > 
> > Also note that ‘HAVE_OCAML’ changes meaning slightly, so it now means
> > "build OCaml bindings and tools" (analogous to ‘HAVE_PERL’ and
> > others).  The generator, daemon [in a future commit], and some utility
> > libraries needed by the generator or daemon do not test for this macro
> > because we can assume OCaml compiler availability.
> > ---
> 
> This LGTM, although i'd have taken one step further and always build
> all the OCaml stuff regardless (so removing --disable-ocaml, or making
> it show a "this is void now" message).

‘--disable-ocaml’ could be useful to some.  It could be useful to
Fedora here:

http://pkgs.fedoraproject.org/cgit/rpms/libguestfs.git/tree/libguestfs.spec#n913

For some reason we're not using ‘--disable-ocaml’ there, but I think
that was probably something to do with requiring the generator to be
run, and we could revisit that to speed up Fedora builds.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/