[Libguestfs] [PATCH 01/27] build: Make OCaml compiler required for all builds.

[Richard W.M. Jones]

On Tue, Jul 18, 2017 at 06:13:11PM +0200, Pino Toscano wrote:
> On Friday, 14 July 2017 15:39:09 CEST Richard W.M. Jones wrote:
> > +dnl Check for <caml/unixsupport.h> header.
> > +old_CPPFLAGS="$CPPFLAGS"
> > +CPPFLAGS="$CPPFLAGS -I`$OCAMLC -where`"
> > +AC_CHECK_HEADERS([caml/unixsupport.h],[],[],[#include <caml/mlvalues.h>])
> > +CPPFLAGS="$old_CPPFLAGS"
> 
> The minimum version of OCaml is 3.11, and it seems to have this header
> already; since at least patch #2 uses it unconditionally, I'd add a
> patch after this to drop its search, and all the HAVE_CAML_UNIXSUPPORT_H
> blocks all around.

Indeed it does.  I pushed this change:

https://github.com/libguestfs/libguestfs/commit/ffdcb7cfebcac17fcbfde91283fd554ea90bcbf4

Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top