[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] lib: direct, uml: Unblock SIGTERM in the hypervisor and recovery processes (RHBZ#1460338).



On Saturday, 10 June 2017 19:33:12 CEST Richard W.M. Jones wrote:
> If SIGTERM is blocked in the main program, then it ends up still being
> blocked in the subprocess after we fork.  This means that we cannot
> kill qemu by sending SIGTERM to it.  This commit fixes the problem by
> unblocking SIGTERM unconditionally after fork.
> 
> Thanks: wtfuzz on IRC for reporting and analysis.
> ---

LGTM, although a macro/function to avoid copy&pasting the same snippet
4 times would be better IMHO.

Thanks,
-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]