[Libguestfs] [PATCH] v2v: -o null: Force output format to be raw sparse.

[Pino Toscano]

On Friday, 10 March 2017 15:04:04 CET Richard W.M. Jones wrote:
> When converting and throwing away the output (-o null), the input
> format should not really matter.  However it does currently matter for
> a couple of reasons:
> 
> (1) If the input is not raw or qcow2, then you'll get the error below
> because virt-v2v wants to write the same output format as input format
> but only allows raw or qcow2 as output formats:
> 
>   virt-v2v: error: output format should be 'raw' or 'qcow2'.
> 
> (2) If you use -o null -oa preallocated then a non-sparse temporary
> disk is created before being deleted, but that just wastes disk space
> for no reason.
> 
> Therefore this change
> 
> (i) prevents '-o null -oa preallocated' from being specified on the
> command line,
> 
> (ii) prevents '-o null -of <anything>',
> 
> (iii) forces the output (temporary file) to be raw sparse.
> ---

LGTM.

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20170310/cce112a6/attachment.sig>