[Libguestfs] [PATCH] mllib: Add a binding for realpath(3).

Pino Toscano ptoscano at redhat.com
Mon Mar 13 12:46:34 UTC 2017


In data lunedì 13 marzo 2017 12:26:12 CET, Richard W.M. Jones ha scritto:
> This is a copy of the supermin binding:
> 
> https://github.com/libguestfs/supermin/tree/master/src realpath*
> ---

LGTM, just one small note:

> diff --git a/mllib/unix_utils-c.c b/mllib/unix_utils-c.c
> index f5aaaf6..7e90541 100644
> --- a/mllib/unix_utils-c.c
> +++ b/mllib/unix_utils-c.c
> @@ -25,6 +25,7 @@
>  #include <unistd.h>
>  #include <fcntl.h>
>  #include <fnmatch.h>
> +#include <limits.h>

Most probably this header is not needed.

Thanks,
-- 
Pino Toscano




More information about the Libguestfs mailing list