[Libguestfs] [PATCH libguestfs] Use AC_HEADER_MAJOR to find definitions of major, minor, makedev.

Pino Toscano ptoscano at redhat.com
Fri Mar 3 14:45:30 UTC 2017


On Wednesday, 1 March 2017 13:20:02 CET Richard W.M. Jones wrote:
> Note this requires either the following fix in autoconf:
> 
> http://git.savannah.gnu.org/cgit/autoconf.git/commit/?id=e17a30e98
> 
> OR gnulib sys_types module plus gnulib
> commit a512e041120e9012e69afa2f5c3adc196ec4999a (any gnulib more
> recent than Sep 2016) which corrects the AC_HEADER_MAJOR macro in a
> similar way.
> ---

Theoretically LGTM -- OTOH, couldn't the common #if..etc chain be put
in some common headers, e.g. guestfs-internal-all.h? Or a simple
guestfs-internal-majorminor.h or so.

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20170303/25e9639e/attachment.sig>


More information about the Libguestfs mailing list