[Libguestfs] [PATCH] erlang: Rename 'message' to something less generic.

Pino Toscano ptoscano at redhat.com
Fri Mar 3 14:56:25 UTC 2017


On Friday, 3 March 2017 11:17:53 CET Richard W.M. Jones wrote:
> It's not possible to define an action which takes a parameter called
> 'message' because the Erlang bindings use that as the name of an
> internal variable.  Solve this by renaming the Erlang internal
> variable.
> 
> Fixes commit 84763d7fca3668c62ee3fe53d0e00a5a672f687b.
> ---

LGTM -- if that variable is in a place that can conflict with action
stuff, then I guess using 'erl_args_tuple' could reduce the likelihood
of conflict even more.

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20170303/f85bfe1b/attachment.sig>


More information about the Libguestfs mailing list