[Libguestfs] [PATCH 01/11] java: link libguestfs_jni against libutils

Pino Toscano ptoscano at redhat.com
Fri Mar 3 15:12:26 UTC 2017


On Friday, 3 March 2017 16:05:34 CET Richard W.M. Jones wrote:
> On Fri, Mar 03, 2017 at 03:32:55PM +0100, Pino Toscano wrote:
> > The JNI library uses CLEANUP_FREE macros, whose functions are built in
> > the internal libutils.  Currently, trying to use functions that use
> > CLEANUP_FREE variables will cause the java execution to stop with a
> > symbol lookup error (for guestfs_int_cleanup_free).
> 
> [comment only]
> I wonder why our tests didn't pick this up?

CLEANUP_FREE was used (before this patch series) only for FBuffer
elements of structs, used only in the "xattr" struct; only few APIs
return a list of "xattr" structs: lxattrlist, getxattrs, lgetxattrs,
and internal_lxattrlist, and none of them is tested in Java tests.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20170303/91f3fad9/attachment.sig>


More information about the Libguestfs mailing list