[Libguestfs] [PATCH 1/2] Use gnulib set_nonblocking_flag function instead of fcntl.

Pino Toscano ptoscano at redhat.com
Mon Mar 6 09:11:21 UTC 2017


On Friday, 3 March 2017 16:00:22 CET Richard W.M. Jones wrote:
> The previous code:
> 
>   fcntl (fd, F_SETFL, O_NONBLOCK)
> 
> was technically incorrect, because it would have reset any
> other flags on the file descriptor.
> 
> Thanks: Eric Blake
> ---

The series LGTM.

As additional work for NONBLOCK, I'd use set_nonblocking_flag instead
of SOCK_NONBLOCK in the only usage of it in accept4, i.e.
lib/launch-libvirt.c, so we can get rid of one of the (IMHO) wrong
definitions for non-Linux added by commit
7ddf6bcbfdc66855b594afaaacdc4998177f2286.

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20170306/1d4a68cc/attachment.sig>


More information about the Libguestfs mailing list