[Libguestfs] [PATCH] bash: Add a bash completion script for virt-v2v-copy-to-local (RHBZ#1367738).

[Pino Toscano]

On Wednesday, 22 March 2017 16:53:25 CET Richard W.M. Jones wrote:
> On Wed, Mar 22, 2017 at 11:39:58AM +0100, Pino Toscano wrote:
> > On Wednesday, 22 March 2017 11:30:59 CET Richard W.M. Jones wrote:
> > > Thanks: Ming Xie
> > > ---
> > 
> > It does not wrong to me, although couldn't an existing completion be
> > used for virt-v2v-copy-to-local as well?
> 
> We might have used the 'virt-alignment-scan' one (used by all the
> other virt-* tools except virt-v2v), but it is considerably more
> complicated than needed for this tool.

The virt-rescue or guestmount ones (which btw are the very same!) are
far simplier than virt-alignment-scan, they only add libvirt domain
completion.

> As far as I could see there is
> no completion function which just completes short and long options
> with no other magic.  Perhaps one is needed, and perhaps this is the
> one!

The aforementioned virt-rescue/guestmount could be a choice, but
otherwise no objection to this.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20170322/fa79cbf1/attachment.sig>