[Libguestfs] [PATCH] v2v: xen: Require direct backend when doing Xen conversions over SSH.

Pino Toscano ptoscano at redhat.com
Thu Mar 23 08:33:19 UTC 2017


On Wednesday, 22 March 2017 16:46:13 CET Richard W.M. Jones wrote:
> From: "Richard W.M. Jones" <rjones at redhat.com>
> 
> Unfortunately libvirt has another bug related to the qemu
> ssh driver, as described here:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1434651#c3
> 
> Until this bug is fixed we have to require the direct backend to be
> used for xen+ssh conversions.
> 
> This partially reverts commit ecbf09385033ba0acf14e914927ec81ad20a5308.
> ---
>  v2v/input_libvirt_xen_ssh.ml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/v2v/input_libvirt_xen_ssh.ml b/v2v/input_libvirt_xen_ssh.ml
> index 4975eff..a68cdf8 100644
> --- a/v2v/input_libvirt_xen_ssh.ml
> +++ b/v2v/input_libvirt_xen_ssh.ml
> @@ -38,6 +38,9 @@ object
>      debug "input_libvirt_xen_ssh: source: scheme %s server %s"
>            scheme server;
>  
> +    if backend_is_libvirt () then (
> +      error (f_"because of libvirt bug https://bugzilla.redhat.com/1434651 you must set this environment variable:\n\nexport LIBGUESTFS_BACKEND=direct\n\nand then rerun the virt-v2v command.")
> +    );

LGTM if you amend the bug number to RHBZ#1140166 in commit log and
error message.

Should this also be documented briefly in the manual? I.e. mention that,
due to libvirt limitations, Xen conversions using the libvirt backend
will not work, and this the direct backend is needed.

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20170323/17bc301a/attachment.sig>


More information about the Libguestfs mailing list