[Libguestfs] [PATCH 2/3] Use Unicode single quotes ‘’ in place of `' in strings throughout.

Richard W.M. Jones rjones at redhat.com
Fri Mar 31 13:54:02 UTC 2017


On Fri, Mar 31, 2017 at 08:10:48AM -0500, Eric Blake wrote:
> On 03/31/2017 04:32 AM, Richard W.M. Jones wrote:
> > See: https://www.cl.cam.ac.uk/~mgk25/ucs/quotes.html
> > ---
> 
> > +++ b/align/scan.c
> > @@ -76,7 +76,7 @@ static void __attribute__((noreturn))
> >  usage (int status)
> >  {
> >    if (status != EXIT_SUCCESS)
> > -    fprintf (stderr, _("Try `%s --help' for more information.\n"),
> > +    fprintf (stderr, _("Try ‘%s --help’ for more information.\n"),
> >               getprogname ());
> 
> The `' form of quoting is definitely out of style. But these days, it is
> debatable whether ASCII '' or Unicode ‘’ is better as the default; since
> it is still not guaranteed that everyone is using a UTF-8 console.
> Coreutils uses '', if that helps the decision any, but I'm fine with
> whatever you think looks best.

Assuming someone is using a non-utf-8 encoding (say euc-jp or
iso-8859-1), will these quotes be displayed properly?  I mean, does
any conversion get done, or are the byte sequences simply dumped out
to the console?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v




More information about the Libguestfs mailing list