[Libguestfs] [PATCH v2] RHBZ#1406906: check return value of Python object functions
Pino Toscano
ptoscano at redhat.com
Mon May 15 12:36:19 UTC 2017
On Thursday, 11 May 2017 20:21:39 CEST Matteo Cafasso wrote:
> Verify the returned values of Python Object constructor functions
> are not NULL before adding them to a collection.
>
> This is particularly relevant when constructing Unicode strings in
> Python 3 as they will return NULL if non UTF-8 characters are present.
>
> Signed-off-by: Matteo Cafasso <noxdafox at gmail.com>
> ---
LGTM -- the only thing to change is the first line of the commit
message, which should be like "python: ... (RHBZ#...)". Not going to
ask you to respin a v3 just because of that, though.
Amended, and pushed. I will close the bug soon too.
Thanks,
--
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20170515/748eff28/attachment.sig>
More information about the Libguestfs
mailing list