[Libguestfs] [PATCH] daemon: ldm: avoid manual free()
Richard W.M. Jones
rjones at redhat.com
Fri Nov 3 21:25:03 UTC 2017
On Fri, Nov 03, 2017 at 05:31:19PM +0100, Pino Toscano wrote:
> When the LDM code was converted to the CLEANUP_* macros, a free()
> invocation for a CLEANUP_FREE variable was left in the
> ldmtool_diskgroup_volumes implementation, causing double-free on
> success.
>
> Updates commit 950951c67de61da27dceca8ffb2079031c13e43b.
> ---
> daemon/ldm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/daemon/ldm.c b/daemon/ldm.c
> index 1bab28989..2f4d2aef3 100644
> --- a/daemon/ldm.c
> +++ b/daemon/ldm.c
> @@ -286,7 +286,6 @@ do_ldmtool_diskgroup_volumes (const char *diskgroup)
> reply_with_error ("%s", err);
> return NULL;
> }
> - free (err);
>
> return parse_json_get_object_string_list (out, "volumes",
> __func__, "ldmtool show diskgroup");
> --
> 2.13.6
Ouch. I guess we don't test this API ..?
ACK.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
More information about the Libguestfs
mailing list