[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [nbdkit PATCH] maint: Rebuild nbdkit if nbdkit.in changes



On 11/16/2017 05:49 AM, Richard W.M. Jones wrote:
> On Wed, Nov 15, 2017 at 10:50:06AM -0600, Eric Blake wrote:
>> Tell automake that we want ./nbdkit to be kept up-to-date in the
>> developer's tree.  Otherwise, after touching nbdkit.in, you would
>> have to remember to manually run 'make nbdkit'.
>>
>> Signed-off-by: Eric Blake <eblake redhat com>
>> ---
>>  Makefile.am | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Makefile.am b/Makefile.am
>> index 315aa36..7815258 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -39,6 +39,8 @@ EXTRA_DIST = \
>>  	valgrind-suppressions \
>>  	m4/.gitignore
>>
>> +noinst_SCRIPTS = nbdkit
>> +
>>  SUBDIRS = \
>>  	docs \
>>  	include \
> 
> ACK
> 
> This is missing from a few places in libguestfs too ...

I haven't tried building libguestfs yet, so I'd rather leave those
additional cross-project improvements to you for now; but the nbdkit
patch is pushed (proving my commit rights now work).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]