[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [nbdkit PATCH v2 0/2] add nbd plugin

On 11/16/2017 05:53 AM, Richard W.M. Jones wrote:
> ACK series, with one minor change:
> Please add a reference to the new manual page in the ‘SEE ALSO’
> section at the bottom of the following two files:
>   docs/nbdkit.pod

This one is obvious; I also added:

diff --git i/docs/nbdkit.pod w/docs/nbdkit.pod
index 155fcb5..e3043ba 100644
--- i/docs/nbdkit.pod
+++ w/docs/nbdkit.pod
@@ -463,6 +463,7 @@ Some common clients and the protocol they require:
  nbd-client < 3.10               client can talk either protocol
  nbd-client >= 3.10              newstyle
  any TLS (encrypted) client      newstyle
+ nbdkit nbd plugin               client can talk either protocol

 If you use qemu E<le> 2.5 without the exportname field against a
 newstyle server, it will give the error:

>   docs/nbdkit-plugin.pod

This one seems to focus more on the cross-language bindings (the SEE
ALSO does not mention nbdkit-file-plugin, for example), so I'm not sure
if you still want it there. We could always do a followup to expand the
list of SEE ALSO to all nbdkit-related pages, but that's more than just
nbd, so I left that file unchanged for now.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]