[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [nbdkit PATCH v2 1/2] nbd: Add new nbd forwarding plugin



On Fri, Nov 17, 2017 at 10:56:57PM +0000, Richard W.M. Jones wrote:
> 
> This one introduces a warning (error because I'm using -Werror):
> 
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../../src -Wall -Werror -g -O2 -MT nbdkit_nbd_plugin_la-nbd.lo -MD -MP -MF .deps/nbdkit_nbd_plugin_la-nbd.Tpo -c nbd.c  -fPIC -DPIC -o .libs/nbdkit_nbd_plugin_la-nbd.o
> nbd.c: In function ‘nbd_reply’:
> nbd.c:306:19: error: ‘trans.cookie’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>    assert (err < 0 || cookie == trans.cookie);
>                    ^~
> cc1: all warnings being treated as errors
> make[3]: *** [Makefile:531: nbdkit_nbd_plugin_la-nbd.lo] Error 1

Thanks for the fix.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]