[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v13 0/3] virt-builder-repository



On Tue, 2017-11-21 at 17:00 +0000, Richard W.M. Jones wrote:
> I pushed this now, thanks.
> 
> I made a few fixes:
> 
>  - Trailing whitespace in a few places.

Hum, I should really automate their cleanup when saving files.

>  - The "--keep-index" option was documented but does not appear to
>    exist in the tool itself.  test-docs.sh caught this.

Oops, indeed I removed that option due to a comment of yours, but forgot
to adapt the doc...

>  - index_parser_tests.ml did not build.

... and I forgot to run the tests: not good at all.

>  - Updated website.html.in.

Thanks for your (and Pino's) numerous reviews on that series!

--
Cedric


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]