[Libguestfs] [PATCH 0/1] RFC: switch from YAJL to Jansson

Pino Toscano ptoscano at redhat.com
Thu Nov 23 13:23:51 UTC 2017


Hi,

recently, there was a discussion in the development list of libvirt on
switching to a different JSON library than YAJL [1].  Since we use YAJL,
and the points there IMHO apply to libguestfs as well, I decided to give
a try in switching to Jansson [2].

The result IMHO is nice, with the additional APIs of Jansson that
simplify some of our code.  Unlike with YAJL, I did not set a minimum
required version, as I did not use any feature in newer versions (simply
because there was no need for them), so even older versions should work.
Of course the test suite works for me, although it does not cover the
LDM APIs.

What do you think?

[1] https://www.redhat.com/archives/libvir-list/2017-November/msg00225.html
[2] http://www.digip.org/jansson/

Pino Toscano (1):
  Switch from YAJL to Jansson

 appliance/packagelist.in            |  13 ++--
 builder/Makefile.am                 |   4 +-
 builder/yajl-c.c                    |  66 ++++++++++-----------
 builder/yajl_tests.ml               |   4 +-
 contrib/p2v/aux-scripts/do-build.sh |   8 +--
 contrib/p2v/build-p2v-iso.sh        |   3 +-
 daemon/Makefile.am                  |   4 +-
 daemon/ldm.c                        | 115 ++++++++++++++++--------------------
 docs/guestfs-building.pod           |   2 +-
 lib/Makefile.am                     |   4 +-
 lib/info.c                          | 113 ++++++++++++++---------------------
 lib/qemu.c                          |  64 +++++++-------------
 m4/guestfs-libraries.m4             |   4 +-
 13 files changed, 170 insertions(+), 234 deletions(-)

-- 
2.13.6




More information about the Libguestfs mailing list