[Libguestfs] [PATCH 0/9] build: Require OCaml >= 4.02.

[Pino Toscano]

On Wednesday, 4 October 2017 14:56:21 CEST Richard W.M. Jones wrote:
> Per my previous email:
> https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html
> I'd like to talk about requiring a more modern version of the OCaml
> compiler.
> 
> These commits show some of the code changes which would be possible
> with OCaml >= 3.12 [which it turns out we already require by accident]
> and also with OCaml >= 4.02.  The latter is my favoured option.

For sure, IMHO we can raise the OCaml requirement to >= 4.01: it would
be a first step, and there are various things that can be used already
with that version:
- the { field } matching style (your patch #2)
- the new Filename methods (your patch #4)
- dropping some of the stuff in Std_utils, e.g. iteri, mapi, and (|>)
- Unix.O_CLOEXEC instead of Unix.set_close_on_exec

So I'd say:
- ACK to patch #1, changed to 4.01
- ACK (after fixes following my comments) to patch #2
- ACK to patches #4, #5, #6, #7, and #8

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20171004/94478ca3/attachment.sig>