[Libguestfs] [PATCH v12 02/11] common: Bundle the ocaml-augeas library for use by the daemon.

[Richard W.M. Jones]

On Tue, Sep 12, 2017 at 06:41:36PM +0200, Pino Toscano wrote:
> On Wednesday, 9 August 2017 19:23:37 CEST Richard W.M. Jones wrote:
> > This commit bundles the ocaml-augeas library (upstream here:
> > http://git.annexia.org/?p=ocaml-augeas.git;a=summary).  It's identical
> > to the upstream version and should remain so.
> > 
> > We can work towards using system ocaml-augeas, when it's more widely
> > available.
> > ---
> 
> IMHO it would be better if the Augeas.Error exception had all the
> available details, i.e. code, error message, minor message, and details.
> Right now it does not even include any of those, so it is hard for
> users to differentiate the error handling depending on the actual error.
> Also, IMHO failures related to ENOMEM should caml_raise_out_of_memory().
> 
> I guess this is not doable anymore, to avoid breaking the ocaml-augeas
> API?  If it is doable, I'm willing to cook up a patch.

I'm not really fussed about that API.  The only constraint is that
this change would have to go into ocaml-augeas (ie. the upstream
project) first.  If you want to have a go at a patch then please do.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW