[Libguestfs] [PATCH v12 04/11] New API: Deprecate hivex_value_utf8 and replace with hivex_value_string.

Pino Toscano ptoscano at redhat.com
Tue Sep 12 16:42:11 UTC 2017


On Wednesday, 9 August 2017 19:23:39 CEST Richard W.M. Jones wrote:
> hivex has a function hivex_value_string.  We were not calling it under
> the mistaken belief that because hivex implements this using iconv,
> the function wouldn't work inside the daemon.  Instead we
> reimplemented the functionality in the library.
> 
> This commit deprecates hivex_value_utf8 and removes the library side
> code.  It replaces it with a plain wrapper around hivex_value_string.
> 
> Thanks: Pino Toscano
> ---

The only thing here is that I would leave hivex_value_utf8 as non-daemon
function, just to avoid adding an extra daemon function.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20170912/51998963/attachment.sig>


More information about the Libguestfs mailing list