[Libguestfs] [PATCH nbdkit] python: Turn python exceptions into nbdkit errors

Richard W.M. Jones rjones at redhat.com
Thu Apr 5 13:31:25 UTC 2018


On Thu, Apr 05, 2018 at 02:05:12PM +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 05, 2018 at 01:47:30PM +0100, Richard W.M. Jones wrote:
> > Much more annoying that it needs to be, but I have tested it and it
> > works on Python 2 & 3.  Note this will not work on Python 3.0 - 3.2,
> > but I guess we don't care about those versions.
> 
> What's the problem that impacts 3.0 -> 3.2 ?   I don't particularly
> care, just curious really.  Perhaps mention the problem in the commit
> message as a hint for anyone who does care

It's just that PyUnicode_AsUTF8 was added in 3.3.
(https://docs.python.org/3/c-api/unicode.html)

We could add a workaround fairly easily, but I don't think we
care about this range of old versions now.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v




More information about the Libguestfs mailing list