[Libguestfs] [PATCH] v2v: Verify that ’source.s_disks.s_disk_id‘s are all unique.

[Richard W.M. Jones]

---
 v2v/v2v.ml | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/v2v/v2v.ml b/v2v/v2v.ml
index 09bc4f37d..1775200d3 100644
--- a/v2v/v2v.ml
+++ b/v2v/v2v.ml
@@ -31,6 +31,7 @@ open Utils
 open Cmdline
 
 module G = Guestfs
+module IntSet = Set.Make(struct let compare = compare type t = int end)
 
 (* Conversion mode, either normal (copying) or [--in-place]. *)
 type conversion_mode =
@@ -234,10 +235,15 @@ and open_source cmdline input =
 
   if source.s_disks = [] then
     error (f_"source has no hard disks!");
-  List.iter (
-    fun disk ->
-      assert (disk.s_qemu_uri <> "");
-  ) source.s_disks;
+  let () =
+    let ids = ref IntSet.empty in
+    List.iter (
+      fun { s_qemu_uri; s_disk_id } ->
+        assert (s_qemu_uri <> "");
+        (* Check s_disk_id are all unique. *)
+        assert (not (IntSet.mem s_disk_id !ids));
+        ids := IntSet.add s_disk_id !ids
+    ) source.s_disks in
 
   source
 
-- 
2.18.0