[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v2 nbdkit 1/6] filters: Call all .prepare and .finalize methods, not just the first one.



On 08/01/2018 06:10 AM, Richard W.M. Jones wrote:
These methods are not chained through the next_ops structure, so we
must do that work in src/filters.c.

This fixes the behaviour of filters when you layer multiple filters in
front of a plugin.
---
  src/filters.c | 27 +++++++++++++++++++--------
  1 file changed, 19 insertions(+), 8 deletions(-)

And at least test-fua.sh breaks, because the log filter is used as a second filter, and now outputs more information that needs to be accounted for. The change is desirable, so we just have to adjust the test to match.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]