[Libguestfs] [PATCH v2 nbdkit 3/6] filters: Print filter name in debugging messages.

Eric Blake eblake at redhat.com
Wed Aug 1 14:11:14 UTC 2018


On 08/01/2018 06:10 AM, Richard W.M. Jones wrote:
> nbdkit_debug implicitly prints the plugin name.  However this leads to
> confusing debug messages such as:
> 
>    nbdkit: pattern[1]: debug: prepare
>    nbdkit: pattern[1]: debug: prepare
> 
> (in this instance, two different prepare functions were called in
> different filters, but neither filter name was shown).
> 
> By printing the filter name in the debug message we improve the output:
> 
>    nbdkit: pattern[1]: debug: truncate: prepare
>    nbdkit: pattern[1]: debug: map: prepare
> 
> Another example of the improved output is:
> 
>    nbdkit: pattern[1]: debug: truncate: can_flush     # filter
>    nbdkit: pattern[1]: debug: map: can_flush          # filter
>    nbdkit: pattern[1]: debug: can_flush               # plugin

Yes, much easier to debug (even if the examples in the commit message 
require later patches before I can actually reproduce them).

ACK.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org




More information about the Libguestfs mailing list