[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] v2v: rhv-plugin: Use string literal concatenation



On Mon, Aug 6, 2018 at 1:27 PM Richard W.M. Jones <rjones redhat com> wrote:
On Mon, Aug 06, 2018 at 12:11:31PM +0300, Nir Soffer wrote:
> On Mon, Aug 6, 2018 at 11:02 AM Richard W.M. Jones <rjones redhat com>
> wrote:
>
> > On Sun, Aug 05, 2018 at 04:37:31PM +0300, Nir Soffer wrote:
> > > When splitting long strings over multiple lines, we can use string
> > > literal concatenation instead of +.
> > >
> > > See
> > https://docs.python.org/3/reference/lexical_analysis.html#string-literal-concatenation
> > > ---
> > >  .gnulib                  |  2 +-
> >
> > I dropped the accidental gnulib part of this commit :-)
> >
>
> Sorry about that :-)
>
> I think I did:
> git pull
> git checkout -b ...
> edit file
> git commit

I wonder if you used ‘git commit -a’ which would have added all
changes from the local directory, and thus included ‘.gnulib’. 

I never use "git commit -a" for this reason. I used "make" and "git add -u", and
it did pick up the changes in the submodule. Maybe we need to ignore
these?

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]