[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH nbdkit] protocol: Implement NBD_OPT_GO.



On 08/06/2018 02:54 AM, Richard W.M. Jones wrote:
On Sun, Aug 05, 2018 at 12:11:04AM +0300, Nir Soffer wrote:
But we have a bug - server configure to allow access to "export",
but allow access to the default empty "" export.

nbdkit ignores the export name you pass in and always has done:

https://github.com/libguestfs/nbdkit/blob/a2c4e88af503310892ebce6da3ac478beb47888a/src/connections.c#L626

The -e option on the command line is only for advertizing an export
name to clients.  It is otherwise unused & unenforced.

Agreed - it is not necessarily a bug for the server to permit the client to connect to different name(s) than what the server was told to advertise.


One day we'll do something useful with it but we're not sure what.

We might eventually reject clients that don't request the same export name as what was advertised, but that doesn't make the current behavior buggy (it only means that current clients shouldn't rely on a mismatched name always working).

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]