[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH nbdkit] protocol: Implement NBD_OPT_GO.

On 08/06/2018 09:31 AM, Nir Soffer wrote:
Eric, can you point us to the part of the spec allowing ignoring the export
name sent by the client?

Nothing in the NBD spec requires the server to reject unknown export names. So nbdkit never rejects export names (which means it behaves as if all names work, regardless of whether or not it was the name it was configured with, since it exports exactly one volume all the time).

An NBD server that exports more than one volume at a time (such as qemu via QMP [but oddly not qemu-nbd], or nbd-server) DOES have to pay attention to export names. And if nbdkit were ever taught to manage more than one export at once, then that would also imply that export names matter. But until then, I don't see nbdkit's behavior as a spec violation.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]