[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH nbdkit v2] protocol: Implement NBD_OPT_GO.



On Mon, Aug 06, 2018 at 09:02:14AM -0500, Eric Blake wrote:
> On 08/06/2018 07:03 AM, Richard W.M. Jones wrote:
> >Actually I was wrong, there *is* one substantive change over v1, which
> >is this:
> >
> >>+  /* The client is buggy.  The last option must be NBD_OPT_GO or
> >>+   * NBD_OPT_EXPORT_NAME.
> >>+   */
> >>+  else {
> >>+    nbdkit_error ("client options list didn't finish with NBD_OPT_GO "
> >>+           "or NBD_OPT_EXPORT_NAME");
> >>+    return -1;
> >>+  }
> 
> As I pointed out in the other mail, this else clause is unreachable.

Understood.  I initially believed it was reachable if nr_options ==
MAX_NR_OPTIONS but we check that case previously.

Thanks for the review,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]