[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v2 1/4] file: Avoid unsupported fallocate() calls



On Mon, Aug 13, 2018 at 11:58 PM Nir Soffer <nsoffer redhat com> wrote:
On Mon, Aug 13, 2018 at 8:44 PM Eric Blake <eblake redhat com> wrote:
>   #ifdef FALLOC_FL_ZERO_RANGE
> -  r = do_fallocate (h->fd, FALLOC_FL_ZERO_RANGE, offset, count);
> -  if (r == -1 && errno != EOPNOTSUPP) {
> -    nbdkit_error ("zero: %m");
> +  if (h->can_zero_range) {
> +    r = do_fallocate (h->fd, FALLOC_FL_ZERO_RANGE, offset, count);
> +    if (r== 0)

Spacing is off.

It does look off in my mail client (inbox), but looks fine (2 spaces indentation)
in my editor.

Nir

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]